refactor(agents): remove per-agent muster token machinery, forward-token only#198
Open
QuentinBisson wants to merge 1 commit into
Open
refactor(agents): remove per-agent muster token machinery, forward-token only#198QuentinBisson wants to merge 1 commit into
QuentinBisson wants to merge 1 commit into
Conversation
…ken only With M2M removed, the static SA-token path (muster-token-init Job, muster-refresh CronJob, token pod-spec helper, Secret-writer RBAC, and the headersFrom Authorization on the per-agent muster RemoteMCPServer) served no remaining mode. The RemoteMCPServer now carries no static credentials: the propagated muster on-behalf-of token is the only Authorization. The agents.definitions.<agent>.obo flag and the agents.muster image/TTL/schedule values are removed with it. docs/authentication.md describes the forward-token model (one muster-issued token, validated and forwarded byte-identical).
fiunchinho
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session 4 of the OBO single-token refactor (stack: giantswarm/mcp-oauth#496, giantswarm/muster#947, giantswarm/mcp-kubernetes#535, giantswarm/mcp-prometheus#245, giantswarm/mcp-observability-platform#138).
With M2M gone (#197), the per-agent static SA-token path had no remaining consumer. Agents reach muster exclusively on behalf of a user: kagent exchanges the caller's token plus the agent's projected SA token at muster's
/oauth/token(RFC 8693) and propagates the single muster-issued token; muster validates it on/mcpand forwards it byte-identical toforwardTokenbackends.Removed from
agentic-platform-connectivity(and the umbrella defaults):muster-token-initJob,muster-refreshCronJob, the shared token pod-spec helper, and the Secret-writer Role/RoleBindingheadersFromAuthorizationon the per-agent musterRemoteMCPServeragents.definitions.<agent>.oboflag (on-behalf-of is the only mode; nothing left to toggle)agents.muster.{kubectlImage,busyboxImage,tokenExpirationSeconds,tokenRefreshSchedule}agents.remoteMcpServers[].tokenSecretnow only accepts a pre-existing Secret. The chart-owned agent ServiceAccount stays: it is the actor identity muster sees on token exchange.docs/authentication.mdOBO section rewritten for the forward-token model.Held in draft until the glean end-to-end run is green; merges after the upstream stack, bottom-up.